Clarified CI Job Token auth. caveats - #1624
Merged
Merged
Conversation
nejch
requested changes
Oct 7, 2021
nejch
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick PR @axl89! Just a small suggestion.
Also, it is likely CI will fail as we use commit messages to generate changelogs.
Maybe amending your commit message to docs(api): clarifiy CI Job Token auth. caveats would help :)
Codecov Report
@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
+ Coverage 87.95% 91.84% +3.88%
==========================================
Files 74 74
Lines 4294 4294
==========================================
+ Hits 3777 3944 +167
+ Misses 517 350 -167
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
force-pushed
the
docs-clarification
branch
from
October 8, 2021 17:41
3774ec2 to
3f423ef
Compare
Member
|
I made the quick fix in the commit message. Thanks again @axl89! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #1620