chore: fix mypy pre-commit hook - #1562
Merged
Merged
Conversation
nejch
marked this pull request as draft
August 1, 2021 12:29
nejch
force-pushed
the
chore/fix-mypy-pre-commit
branch
from
August 1, 2021 12:31
7db1482 to
430c332
Compare
nejch
marked this pull request as ready for review
August 1, 2021 19:00
antti-mikael
reviewed
Aug 3, 2021
javatarz
approved these changes
Aug 3, 2021
Contributor
|
Can we please get this merged? The pre-commit hooks are broken and the The workaround I've been using is to disable |
Member
Author
Sorry, I know this was really annoying! @JohnVillalovos I'm back from the dead 😆 would you be able to take a quick look/merge? |
Member
|
Thanks @nejch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1539.
Additionally, since mypy 0.910 doesn't bundle stubs anymore we need to track them for pre-commit's own virtualenv :/ See pre-commit/pre-commit#730