Skip to content

chore: add type-hints to gitlab/v4/objects/projects.py - #1511

Merged
nejch merged 1 commit into
python-gitlab:masterfrom
JohnVillalovos:jlvillal/testing-type-hints
Jun 13, 2021
Merged

chore: add type-hints to gitlab/v4/objects/projects.py#1511
nejch merged 1 commit into
python-gitlab:masterfrom
JohnVillalovos:jlvillal/testing-type-hints

Conversation

@JohnVillalovos

@JohnVillalovos JohnVillalovos commented Jun 12, 2021

Copy link
Copy Markdown
Member

Adding type-hints to gitlab/v4/objects/projects.py

@codecov-commenter

codecov-commenter commented Jun 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1511 (872dd6d) into master (dc53556) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1511   +/-   ##
=======================================
  Coverage   91.05%   91.06%           
=======================================
  Files          74       74           
  Lines        4148     4152    +4     
=======================================
+ Hits         3777     3781    +4     
  Misses        371      371           
Flag Coverage Δ
cli_func_v4 80.68% <90.90%> (-0.01%) ⬇️
py_func_v4 79.98% <100.00%> (+0.01%) ⬆️
unit 82.20% <95.45%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/projects.py 83.77% <100.00%> (+0.28%) ⬆️

@JohnVillalovos
JohnVillalovos marked this pull request as draft June 12, 2021 17:48
Adding type-hints to gitlab/v4/objects/projects.py
@JohnVillalovos
JohnVillalovos marked this pull request as ready for review June 12, 2021 18:48
@JohnVillalovos JohnVillalovos changed the title WIP: Testing type-hint stuff chore: add type-hints to gitlab/v4/objects/projects.py Jun 12, 2021
@JohnVillalovos
JohnVillalovos requested a review from nejch June 12, 2021 19:41
@nejch
nejch merged commit 8e6aaf5 into python-gitlab:master Jun 13, 2021
@JohnVillalovos
JohnVillalovos deleted the jlvillal/testing-type-hints branch June 13, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants