Skip to content

Use inline anonymous references for external links - #1255

Merged
max-wittig merged 1 commit into
python-gitlab:masterfrom
bittner:docs/fix-external-links-tokens
Jan 29, 2021
Merged

Use inline anonymous references for external links#1255
max-wittig merged 1 commit into
python-gitlab:masterfrom
bittner:docs/fix-external-links-tokens

Conversation

@bittner

@bittner bittner commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

The links to "the official documentation" on tokens are currently broken in the project documentation.

There doesn't seem to be an obvious way to use an alias for identical text labels that link to different targets. With inline links we can work around this shortcoming. Until we know better.

@max-wittig

Copy link
Copy Markdown
Member

Thanks for the MR. Would you mind to change your commit message to comply with the conventional changelog?

docs(cli): use inline anonymous references for external links

@bittner

bittner commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

Done. I left the long comment in the second line. Is that fine?

@max-wittig

Copy link
Copy Markdown
Member

Totally fine. Thanks 👍

There doesn't seem to be an obvious way to use an alias for identical
text labels that link to different targets. With inline links we can
work around this shortcoming. Until we know better.
@max-wittig

Copy link
Copy Markdown
Member

Sorry for ignoring this for so long! Thanks for your MR!

@max-wittig
max-wittig merged commit 762f959 into python-gitlab:master Jan 29, 2021
@bittner
bittner deleted the docs/fix-external-links-tokens branch February 7, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants