Skip to content

chore: use raise..from for chained exceptions (#939)#1059

Merged
max-wittig merged 1 commit into
masterfrom
fix/raise-from
Apr 7, 2020
Merged

chore: use raise..from for chained exceptions (#939)#1059
max-wittig merged 1 commit into
masterfrom
fix/raise-from

Conversation

@nejch

@nejch nejch commented Mar 29, 2020

Copy link
Copy Markdown
Member

Closes #939. Trying to close some older issues that can be fixed with small changes. :P

@nejch nejch marked this pull request as ready for review April 5, 2020 13:37
@nejch nejch requested a review from max-wittig April 5, 2020 13:37
@nejch nejch changed the title fix: use raise..from for chained exceptions (#939) chore: use raise..from for chained exceptions (#939) Apr 5, 2020

@max-wittig max-wittig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! LGTM 👍

@max-wittig max-wittig merged commit 6749859 into master Apr 7, 2020
@nejch nejch deleted the fix/raise-from branch May 30, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proper usage of exceptions under Python3

2 participants