Repository navigation
/groups/:id/members/all for cli does not contain correct parameters #848
Description
Description of the problem, including code/CLI snippet
When using the CLI command: gitlab group-member all [...] the accepted parameters are incorrect. The all "endpoint" should operate just like the list, allowing paging, etc. instead, it seems to have some other specific commands that aren't necessary.
Expected Behavior
Being able to use commands such as,
gitlab group-member all --group-id 212 --page 2gitlab group-member all --group-id 212 --per-page 2 --page 10- etc.
Actual Behavior
gitlab group-member all only accepts:
-h, --help show this help message and exit
--group-id GROUP_ID
--sudo SUDO
--id ID
as specified in the gitlab docs --id is not necessary and you should actually be able to search (probably something to add for the normal list as well.
Specifications
- python-gitlab version: 1.10.0
- API version you are using (v3/v4): v4
- Gitlab server version (or gitlab.com): 12.0.3-ee
Activity
chrisoldwood commentedon Jan 30, 2020
I believe this is related to #593 about the
runner allverb as that behaves in the same way.I used the group member code to work out why the
runner allJSON support was broken but couldn't address the spurious--idargument. I added some thoughts on ticket #593, e.g. anall-runners listalternative object type, and a pointer about where in the CLI handling it might be making the assumption around why the--idargument is mandatory, but know too little at present to make a serious proposal 🙂.I can envisage a possible "hack" where a custom action named
allwould bypass the logic around looking for an object'sidattribute. This would potentially fix both cases but maybe there is some cleaner way of signalling thatallis more likelistand acts on an entire collection instead of a single item?pvshingala1997 commentedon Oct 17, 2020
Can you assign this to me?
fix(members): use new *All objects for *AllManager managers