Skip to content

Fix wrong font choices in cli's set params. Fixes #653#676

Merged
patkan merged 2 commits into
python-escpos:masterfrom
belono:belono/issue653
Feb 21, 2025
Merged

Fix wrong font choices in cli's set params. Fixes #653#676
patkan merged 2 commits into
python-escpos:masterfrom
belono:belono/issue653

Conversation

@belono
Copy link
Copy Markdown
Contributor

@belono belono commented Feb 14, 2025

Description

This fixes #653 by replacing the wrong list of params in the cli's set --font command with the correct ones.

Thanks to @gloriouslyawkwardlife for reporting this issue 🤟 .

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.29%. Comparing base (e39ec9e) to head (b7535e1).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #676   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files          21       21           
  Lines        1679     1679           
  Branches      262      262           
=======================================
  Hits         1365     1365           
  Misses        234      234           
  Partials       80       80           
Flag Coverage Δ
unittests 80.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/escpos/cli.py 78.02% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@belono belono marked this pull request as ready for review February 14, 2025 20:05
@patkan patkan merged commit e383b7a into python-escpos:master Feb 21, 2025
@belono belono deleted the belono/issue653 branch February 21, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why is font selection {left, center, right}?

2 participants