Skip to content

Drop Py37, improve typing and docstrings#544

Merged
patkan merged 26 commits into
masterfrom
split-dependecies
Aug 14, 2023
Merged

Drop Py37, improve typing and docstrings#544
patkan merged 26 commits into
masterfrom
split-dependecies

Conversation

@patkan
Copy link
Copy Markdown
Member

@patkan patkan commented Aug 14, 2023 •
edited
Loading

Description

Drops Py3.7, improves typing and adds a mypy config, improves the docstrings and isorts the imports.

Tested with

If applicable, please describe with which device you have tested.

patkan
patkan commented Aug 14, 2023
View reviewed changes
Comment thread .github/workflows/pythonpackage.yml
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #544 (5231632) into master (2b62c8e) will decrease coverage by 0.34%.
The diff coverage is 96.87%.

❗ Current head 5231632 differs from pull request most recent head c3cd457. Consider uploading reports for the commit c3cd457 to get more accurate results

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   65.48%   65.14%   -0.34%     
==========================================
  Files          12       12              
  Lines        1266     1251      -15     
  Branches      214      214              
==========================================
- Hits          829      815      -14     
+ Misses        383      382       -1     
  Partials       54       54
Flag Coverage Δ
unittests 65.14% <96.87%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/escpos/codepages.py 91.66% <ø> (ø)
src/escpos/image.py 100.00% <ø> (ø)
src/escpos/escpos.py 68.76% <91.66%> (-1.00%) ⬇️
src/escpos/__init__.py 100.00% <100.00%> (ø)
src/escpos/capabilities.py 87.20% <100.00%> (ø)
src/escpos/cli.py 57.35% <100.00%> (-0.62%) ⬇️
src/escpos/config.py 25.00% <100.00%> (-1.67%) ⬇️
src/escpos/exceptions.py 56.48% <100.00%> (ø)
src/escpos/magicencode.py 90.32% <100.00%> (ø)
src/escpos/printer.py 30.55% <100.00%> (+0.39%) ⬆️

patkan
patkan commented Aug 14, 2023
View reviewed changes
Comment thread pyproject.toml Outdated
patkan
patkan commented Aug 14, 2023
View reviewed changes
Comment thread pyproject.toml Outdated
patkan
patkan commented Aug 14, 2023
View reviewed changes
Comment thread pyproject.toml
@patkan patkan changed the title Modernize packaging and split dependecies Drop Py37, improve typing and docstrings Aug 14, 2023
@patkan patkan marked this pull request as ready for review August 14, 2023 22:58
patkan
patkan commented Aug 14, 2023
View reviewed changes
Comment thread src/escpos/codepages.py Outdated
patkan
patkan commented Aug 14, 2023
View reviewed changes
Comment thread tox.ini Outdated
@patkan patkan added this to the v3.0 milestone Aug 14, 2023
@patkan patkan merged commit fbabd8e into master Aug 14, 2023
@patkan patkan deleted the split-dependecies branch August 14, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0

Development

Successfully merging this pull request may close these issues.

1 participant

@patkan