allow single string as signal list for I/O system#315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While use the
iosysmodule, I noticed that the following construct did something unexpected:This is supposed to be a single input, multi-output system, but I got a system with 3 (?) inputs. Turns out that the string
'phi'was being interpreted as an array of length three since I didn't write it explicitly as a tuple,('phi',)and hence it was anarrayof length 3.This PR checks to see if inputs, outputs, or states are a single string object, in which case it assumes you want are specifying a single signal with the string as the name.
I also fixed a small bug where the prefix for setting the default name (if no name string is given for a single) was being ignored.