Make output response matrices consistent between continuous and discrete time#143
Merged
murrayrm merged 2 commits intoApr 21, 2017
Merged
Conversation
roryyorke
reviewed
Apr 18, 2017
roryyorke
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I suppose one could test each of control.timeresp's public functions (this fixes all of them), but it's hardly necessary.
Member
Author
|
Thanks for the review, @roryyorke. Merging into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #142 where the output response matrices were not consistent for continuous and discrete time simulations. The error was in the discrete time simulation, where the conventions used by
spicy.signalare different than those used bypython-control. Also added a unit test that catches this error.