This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Use standard consul environment variables to override configuration#74
Merged
Conversation
Collaborator
|
Sorry for the delay in getting to this. This looks great. Thanks @amayausky! |
cablehead
added a commit
that referenced
this pull request
Feb 7, 2016
Use standard consul environment variables to override configuration
Collaborator
|
What do you think about adding documentation for these? Perhaps in docs/index.rst, between the client section and the tools section? |
Collaborator
|
Uploaded to pypi as v0.6.0 |
mbrulatout
referenced
this pull request
in criteo/py-consul
Aug 28, 2023
Use standard consul environment variables to override configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other Hashicorp tools, envconsul and consul-template, use this set of environment variables to provide configuration for themselves and other consul tools they're integrated with. I've implemented them as overrides to what is normally passed in to the constructor. That seems to make sense since an application can be configured to use the default host/port but then be overridden by providing CONSUL_HTTP_ADDR.