Skip to content

Fix VariableExactSumConstraint forwardcheck incorrectly pruning valid domain values #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaoflow wants to merge 2 commits into from
Closed

Fix VariableExactSumConstraint forwardcheck incorrectly pruning valid domain values #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
897f868
Fix VariableExactSumConstraint forwardcheck double-counting unassigne…
gaoflow Jun 25, 2026
4b61f4a
Merge branch 'main' into fix/variable-exact-sum-forwardcheck
fjwillemsen Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion constraint/constraints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,8 +496,12 @@ def __call__(self, variables: Sequence, domains: dict, assignments: dict, forwar
if temp_sum > target_value:
domain.hideValue(value)
else:
# sum_value already includes min(domain) as a placeholder for this
# unassigned variable; subtract it before adding the candidate value
# to avoid double-counting.
var_placeholder = min(domain)
for value in domain[:]:
temp_sum = sum_value + value
temp_sum = sum_value - var_placeholder + value
if temp_sum > target_value:
domain.hideValue(value)
if not domain:
Expand Down
Loading