Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 23 23
Lines 6473 6473
=======================================
Hits 6457 6457
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History ranges that start past the last entry currently select the final command. For example,
after
mark firstandmark last,history --run 999:executesmark lastagain even thoughthe requested range contains no entries.
Allow the converted start index in
History.span()to reachlen(self)so these ranges areempty. Add regressions for both range separators, boundary behavior, and command replay, plus
a changelog entry. The existing negative-index and inclusive-endpoint behavior is preserved.
Validation on macOS 27.0 arm64 / CPython 3.13.12:
14 passes with the fix. The standalone replay reproduction also fails before and passes after.
make check: passed, including formatting, lint, ty, and mypy.make test: 2,022 passed, 3 skipped; overall coverage 99.4%, history module coverage 100%.make docs-test: strict build passed.git diff --check: passed.AI assistance was used for the investigation, patch, report, and validation. Hosted CI and
maintainer review are pending.
Closes #1777