Skip to content

Check build fails on MacOSX when build as shared with build_with_install_rpath#98

Closed
jcfr wants to merge 1 commit into
python-cmake-buildsystem:masterfrom
jcfr:expected-to-fail-when-shared-and-build-with-install-rpath
Closed

Check build fails on MacOSX when build as shared with build_with_install_rpath#98
jcfr wants to merge 1 commit into
python-cmake-buildsystem:masterfrom
jcfr:expected-to-fail-when-shared-and-build-with-install-rpath

Conversation

@jcfr

@jcfr jcfr commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

THIS COMMIT SHOUD NOT BE INTEGRATED INTO MASTER

The role of the commit is to confirm the build fail and will be effectively
fixed by PR #97.

It also test the feature introduced in 0f8541e teaching the driver
script how to extract additional CMake configuration arguments from the
commit message. This new feature provides a simple way to test some
options without having to explicitly change the CI build matrix.

This is special awesome comment:

[cmake -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON]

jcfr added a commit that referenced this pull request Sep 3, 2015
…e commit

This will allow CMake comment used in #98 to effectively be considered
when configuring the project.
…all_rpath

THIS COMMIT SHOUD NOT BE INTEGRATED INTO MASTER

The role of the commit is to confirm the build fail and will be effectively
fixed by PR python-cmake-buildsystem#97.

It also test the feature introduced in 0f8541e teaching the driver
script how to extract additional CMake configuration arguments from the
commit message. This new feature provides a simple way to test some
options without having to explicitly change the CI build matrix.

This is special awesome comment:

[cmake -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON]
@jcfr jcfr force-pushed the expected-to-fail-when-shared-and-build-with-install-rpath branch from 61b0011 to 66545a4 Compare September 4, 2015 02:56
@jcfr

jcfr commented Sep 4, 2015

Copy link
Copy Markdown
Contributor Author

Closing since #97 has been addressed.

@jcfr jcfr closed this Sep 4, 2015
@jcfr jcfr deleted the expected-to-fail-when-shared-and-build-with-install-rpath branch September 4, 2015 06:02
jrobcary pushed a commit to Tech-XCorp/pythoncm that referenced this pull request Oct 3, 2020
…e commit

This will allow CMake comment used in python-cmake-buildsystem#98 to effectively be considered
when configuring the project.
o01eg pushed a commit to o01eg/python-cmake-buildsystem that referenced this pull request May 24, 2026
…e commit

This will allow CMake comment used in python-cmake-buildsystem#98 to effectively be considered
when configuring the project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant