Skip to content

Indicate pull request source in CDash Build Name.#84

Merged
jcfr merged 1 commit into
python-cmake-buildsystem:dashboardfrom
thewtex:pull-request-in-build-name
Aug 24, 2015
Merged

Indicate pull request source in CDash Build Name.#84
jcfr merged 1 commit into
python-cmake-buildsystem:dashboardfrom
thewtex:pull-request-in-build-name

Conversation

@thewtex

@thewtex thewtex commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

The pull request number is added as documented for Travis at
http://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables

The pull request title and number is added as documented for Appveyor at
http://www.appveyor.com/docs/environment-variables

The pull request number is added as documented for Travis at
http://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables

The pull request title and number is added as documented for Appveyor at
http://www.appveyor.com/docs/environment-variables
Comment thread appveyor_dashboard.cmake

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo # -> $

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The # was intended to indicate the pull request number. I can remove it if preferred.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see ... should it be escaped ? I just want to make sure it is not considered as a CMake comment.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using cmake -P with this content:

set(var_with_hash "this_has_a_#")
message(${var_with_hash})

verifies it should be OK.

@jcfr

jcfr commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

I see looking at the travis error, it tried to build the dashboard branch .. and it failed.

jcfr added a commit that referenced this pull request Aug 24, 2015
Indicate pull request source in CDash Build Name.
@jcfr jcfr merged commit 0641976 into python-cmake-buildsystem:dashboard Aug 24, 2015
o01eg pushed a commit to o01eg/python-cmake-buildsystem that referenced this pull request May 24, 2026
…est-in-build-name

Indicate pull request source in CDash Build Name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants