fix: linking error building _testcapi in Python 3.12 #434#435
Open
Andrej730 wants to merge 3 commits intopython-cmake-buildsystem:masterfrom
Open
fix: linking error building _testcapi in Python 3.12 #434#435Andrej730 wants to merge 3 commits intopython-cmake-buildsystem:masterfrom
_testcapi in Python 3.12 #434#435Andrej730 wants to merge 3 commits intopython-cmake-buildsystem:masterfrom
Conversation
777576c to
31e8fa1
Compare
Author
Error seems unrelated to the change. I've force pushed the branch with the same commit and now 3.9.22 failed, though previously 3.8.20 was failing. |
31e8fa1 to
1f6a6a7
Compare
Author
|
@jcfr can you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #434.
In 3.12
_testcapinow had a file withPy_LIMITED_APIso it was requiringpython3.libto link.https://github.com/python/cpython/blob/3.12/Modules/_testcapi/heaptype_relative.c
Though issue is resolved, it might be still worth investigating why CI didn't catched that error.
@jcfr