Skip to content

Use latest patch versions for testing and default version - #307

Merged
jcfr merged 2 commits into
python-cmake-buildsystem:masterfrom
jamesobutler:use-latest-patch-release
Jan 19, 2022
Merged

jcfr merged 2 commits into
python-cmake-buildsystem:masterfrom
jamesobutler:use-latest-patch-release

Conversation

@jamesobutler

Copy link
Copy Markdown
Contributor

This is a followup PR to what was discussed at #306 (comment).

This updates the ci builds to use the latest patch release of each python minor release and also updates the default built to the latest patch release of the latest python minor version currently supported (3.9).

@jamesobutler

jamesobutler commented Jan 19, 2022 •

Copy link
Copy Markdown
Contributor Author

@jcfr The protected branch rules seem to specify that runs of Python 3.8.5 are required to pass prior to merging and same with python 3.9.9. The ci is being updated here in this PR to trigger runs of Python 3.8.12 and Python 3.9.10 instead, so updating of the required checks will likely need to be updated each time the latest version of the patch release to test is updated. This will be one update step to consider each time this happens.

@jcfr

jcfr commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

All set. Required checks have been updated.

so updating of the required checks will likely need to be updated each time the latest version of the patch release to test is
updated. This will be one update step to consider each time this happens.

Reviewing https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions , I couldn't find a way to specify these outside of the project settings.

Something that could be listed in the maintainers guide ....

@jcfr

jcfr commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

We could also remove the status check but I would rather being explicit and support the auto-merge feature .... https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request#about-auto-merge

@jcfr
jcfr merged commit ee1a661 into python-cmake-buildsystem:master Jan 19, 2022
@jamesobutler
jamesobutler deleted the use-latest-patch-release branch January 19, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants