Make reconnecting to a lost RabbitMQ work.#347
Merged
JamieCressey merged 2 commits intoDec 3, 2015
Conversation
Member
There was a problem hiding this comment.
Probably worth supporting both old and new versions of pika. Pretty easy to check which version in the init of the transport and then just use that one here.
Contributor
Author
|
Here I got to admit that I'm not an actual Python dev, just a dabbler in the art. I have no idea what the best way of doing that would be, but I think I have an alternative... Will push in a second. |
Contributor
Author
|
I don't understand why the kafka tests fail due to my change :/ |
Contributor
Author
|
Actually, I get the same errors when running './setup.py test' on the current master... |
JamieCressey
added a commit
that referenced
this pull request
Dec 3, 2015
Make reconnecting to a lost RabbitMQ work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve issue #346 (which I created myself). I'm not sure why nobody else had this issue, maybe they do not upgrade their RabbitMQ very often! Or it might be because I'm using pika 0.10.0. In any case, this solves the issue. Should I increase the requirement for pika to >=0.10.0 as well?