debian packaging#325
Merged
Merged
Conversation
Contributor
Author
|
I've submitted two more pull request, which are necessary for this one to work properly
Thanks |
Member
|
Why was the name changed from |
Contributor
Author
|
uff, changed it back. How about renaming /etc/beaver to /etc/python-beaver and bin link from /usr/bin/beaver to /usr/bin/python-beaver, so the naming would be more consistent (init script, package name, source location)? |
559096c to
b91ddbd
Compare
Member
|
That sounds fine to me :) |
Contributor
Author
|
changed ;) |
Contributor
Author
There was a problem hiding this comment.
otherwise you'd end up with following error:
Exception:
Traceback (most recent call last):
File "/home/dejv/Workspace/beaver/python-beaver/debian/python-beaver/usr/share/python-beaver/local/lib/python2.7/site-packages/pip-1.1-py2.7.egg/pip/basecommand.py", line 104, in main
status = self.run(options, args)
File "/home/dejv/Workspace/beaver/python-beaver/debian/python-beaver/usr/share/python-beaver/local/lib/python2.7/site-packages/pip-1.1-py2.7.egg/pip/commands/install.py", line 214, in run
InstallRequirement.from_line(name, None))
File "/home/dejv/Workspace/beaver/python-beaver/debian/python-beaver/usr/share/python-beaver/local/lib/python2.7/site-packages/pip-1.1-py2.7.egg/pip/req.py", line 107, in from_line
return cls(req, comes_from, url=url)
File "/home/dejv/Workspace/beaver/python-beaver/debian/python-beaver/usr/share/python-beaver/local/lib/python2.7/site-packages/pip-1.1-py2.7.egg/pip/req.py", line 40, in __init__
req = pkg_resources.Requirement.parse(req)
File "/home/dejv/Workspace/beaver/python-beaver/debian/python-beaver/usr/share/python-beaver/local/lib/python2.7/site-packages/setuptools-0.6c11-py2.7.egg/pkg_resources.py", line 2510, in parse
reqs = list(parse_requirements(s))
File "/home/dejv/Workspace/beaver/python-beaver/debian/python-beaver/usr/share/python-beaver/local/lib/python2.7/site-packages/setuptools-0.6c11-py2.7.egg/pkg_resources.py", line 2436, in parse_requirements
line, p, specs = scan_list(VERSION,LINE_END,line,p,(1,2),"version spec")
File "/home/dejv/Workspace/beaver/python-beaver/debian/python-beaver/usr/share/python-beaver/local/lib/python2.7/site-packages/setuptools-0.6c11-py2.7.egg/pkg_resources.py", line 2404, in scan_list
raise ValueError("Expected "+item_name+" in",line,"at",line[p:])
ValueError: ('Expected version spec in', 'requirements/base.txt', 'at', '/base.txt')
this is because pip will be executed as pip install requirements/base.txt instead of pip install -r requirements/base.txt
I reckon there is no point of having preinstall here, because setuptools handle everything properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes debian packaging and unifies names (username, package name, ...)