Skip to content

Try fixing Travis build#666

Merged
ilevkivskyi merged 5 commits into
masterfrom
fix-ci-pyver
Aug 10, 2019
Merged

Try fixing Travis build#666
ilevkivskyi merged 5 commits into
masterfrom
fix-ci-pyver

Conversation

@ilevkivskyi
Copy link
Copy Markdown
Member

No description provided.

@ilevkivskyi ilevkivskyi force-pushed the fix-ci-pyver branch 2 times, most recently from 2b362a8 to 5074699 Compare August 7, 2019 17:18
@ilevkivskyi
Copy link
Copy Markdown
Member Author

@gvanrossum This fixes the red master (something changed in Travis environment). The fix also discovered that flake8 was not run for long time, so I also fix it.

Could you please take a look?

@gvanrossum
Copy link
Copy Markdown
Member

gvanrossum commented Aug 8, 2019 via email

Comment thread typing_extensions/src_py3/typing_extensions.py
Comment thread typing_extensions/src_py3/typing_extensions.py
Comment thread typing_extensions/src_py3/typing_extensions.py
Copy link
Copy Markdown

@brugz brugz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is my first Code Review on GitHub, so please be kind (or unkind).

Whats the #noqa tag actually doing?

@gvanrossum
Copy link
Copy Markdown
Member

Whats the #noqa tag actually doing?

That's indicating to linters (e.g. flake8, pylint) that they should not complain about that line. There are several tests that intentionally put bad code in a string type annotation or in a type comment (to verify that the typing module handles these correctly), and some linters are smart enough to look inside type comments or string annotations and complain, making the build fail. So the # noqa shuts up the linter and so the build passes.

Comment thread src/test_typing.py Outdated
@ilevkivskyi ilevkivskyi merged commit 00522c4 into master Aug 10, 2019
@ilevkivskyi ilevkivskyi deleted the fix-ci-pyver branch August 10, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants