Try fixing Travis build#666
Conversation
2b362a8 to
5074699
Compare
|
@gvanrossum This fixes the red master (something changed in Travis environment). The fix also discovered that Could you please take a look? |
|
Could you please take a look?
I would, but I am a place with internet so marginal that I can't pull up
GitHub.
Maybe Friday, otherwise the weekend.
|
brugz
left a comment
There was a problem hiding this comment.
Hi, this is my first Code Review on GitHub, so please be kind (or unkind).
Whats the #noqa tag actually doing?
That's indicating to linters (e.g. flake8, pylint) that they should not complain about that line. There are several tests that intentionally put bad code in a string type annotation or in a type comment (to verify that the typing module handles these correctly), and some linters are smart enough to look inside type comments or string annotations and complain, making the build fail. So the |
No description provided.