Skip to content

Improve Step 5 of overload call evaluation. #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rchen152 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Improve Step 5 of overload call evaluation. #2250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
47637e8
Improve Step 5 of overload call evaluation.
rchen152 Apr 8, 2026
045a46b
Merge branch 'main' into overload
rchen152 Apr 8, 2026
fbb847e
Typo fix
rchen152 Apr 8, 2026
89e6130
Remove unsafe overlap in overload example.
rchen152 Apr 8, 2026
4e7c475
Clarifications
rchen152 Apr 8, 2026
891f7ae
Clarification: unpacked arguments
rchen152 Apr 8, 2026
137e3fc
Consistent style
rchen152 Apr 8, 2026
88a046c
Merge branch 'main' into overload
rchen152 Apr 14, 2026
bef8d53
Remove redundant paragraph.
rchen152 Apr 14, 2026
3e07524
More test.
rchen152 Apr 14, 2026
866613b
Merge branch 'main' into overload
rchen152 Apr 17, 2026
7d7a176
Only type vars scoped to the current function should be replaced.
rchen152 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Typo fix
  • Loading branch information
@rchen152
rchen152 committed Apr 8, 2026
commit fbb847ea897e16c23f058645aa1efad22dc50e9c
2 changes: 1 addition & 1 deletion conformance/tests/overloads_evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def example9(x: A[Any]) -> A[Any]:


def check_example9(x: Any):
# Steps 5 eliminates the first overload because there exists a
# Step 5 eliminates the first overload because there exists a
# materialization of `A[Any]` that is not assignable to `A[None]`. Step 6
# picks the second overload.
ret = example9(x)
Expand Down
2 changes: 1 addition & 1 deletion docs/spec/overload.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ Example 5::
def example5(x: A[Any]) -> A[Any]: ...

def test(x: Any):
# Steps 5 eliminates the first overload because there exists a
# Step 5 eliminates the first overload because there exists a
# materialization of `A[Any]` that is not assignable to `A[None]`. Step 6
# picks the second overload.
reveal_type(example5(x)) # Should reveal `A[Any]`
Expand Down