Skip to content

subprocess: use narrower types for TimeoutExpired.std* #8886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 1 commit into from
Oct 12, 2022
Merged

subprocess: use narrower types for TimeoutExpired.std* #8886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
subprocess: use narrower types for TimeoutExpired.std* 
See python/cpython#97685

Thinking we'll go off of mypy_primer to decide if the union type here is
acceptable or not. I'd like us to be able to type this, since the values
being bytes can be surprising if you pass text=True
  • Loading branch information
@hauntsaninja
hauntsaninja committed Oct 12, 2022
commit 90e3d38d5e59d12be816903d66e813fc2ec0c185
4 changes: 2 additions & 2 deletions stdlib/subprocess.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1828,8 +1828,8 @@ class TimeoutExpired(SubprocessError):
timeout: float
# morally: _TXT | None
output: Any
stdout: Any
stderr: Any
stdout: bytes | None
stderr: bytes | None

class CalledProcessError(SubprocessError):
returncode: int
Expand Down