Skip to content

Update importlib.metadata typings for 3.10 #7331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 19 commits into from
Feb 25, 2022
Merged

Update importlib.metadata typings for 3.10 #7331

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
32b37e8
Fix importlib_metadata.metadata typings
itaisteinherz Feb 20, 2022
3f301ec
Update importlib_metadata.metadata.entry_points() typings
itaisteinherz Feb 20, 2022
6395541
Fixup method signature
itaisteinherz Feb 20, 2022
10f183e
Some fixes
itaisteinherz Feb 20, 2022
200fba5
Add missing type hint
itaisteinherz Feb 20, 2022
87f2ea7
Add back `EntryPoints`
itaisteinherz Feb 20, 2022
bfc08ce
Revert incorrect change
itaisteinherz Feb 20, 2022
a10cced
Improvements
itaisteinherz Feb 20, 2022
1f5cd36
CR improvements
itaisteinherz Feb 21, 2022
590cd18
Merge branch 'master' into feature/importlib-metadata-updates
srittau Feb 21, 2022
888abb9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 21, 2022
b7b5a99
Restore property lost during merge
srittau Feb 21, 2022
04fc42a
CR improvements
itaisteinherz Feb 22, 2022
e149789
Add missing ellipsis
itaisteinherz Feb 22, 2022
c761e96
Ignore some errors
itaisteinherz Feb 22, 2022
08e2c31
Mention specific attributes and types instead of `params`
itaisteinherz Feb 22, 2022
1ba3666
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 22, 2022
55a29da
Fix annotation of keyword-only arguments
itaisteinherz Feb 23, 2022
c21677d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some fixes
  • Loading branch information
@itaisteinherz
itaisteinherz committed Feb 20, 2022
commit 10f183e53d67d60b6d99f7a6d79ac6c39bd48063
21 changes: 7 additions & 14 deletions stdlib/importlib/metadata/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,9 @@ if sys.version_info >= (3, 8):
def matches(self, **params: Any) -> bool: ... # undocumented

if sys.version_info >= (3, 10):
class EntryPoints(list): # use as list is deprecated since 3.10
def select(self, **params: Any) -> EntryPoints: ...
@property
def names(self) -> set[str]: ...
@property
def groups(self) -> set[str]: ...

class SelectableGroups(dict): # use as list is deprecated since 3.10
@classmethod
def load(cls, eps) -> EntryPoints: ...
@property
def _all(self) -> EntryPoints: ...
def load(cls, eps) -> SelectableGroups: ...
@property
def groups(self) -> set[str]: ...
@property
Expand Down Expand Up @@ -89,15 +80,17 @@ if sys.version_info >= (3, 8):
if sys.version_info >= (3, 10):
@property
def metadata(self) -> PackageMetadata: ...
@property
def entry_points(self) -> SelectableGroups: ...
else:
@property
def metadata(self) -> Message: ...
@property
def entry_points(self) -> list[EntryPoint]: ...

@property
def version(self) -> str: ...
@property
def entry_points(self) -> list[EntryPoint]: ...
@property
def files(self) -> list[PackagePath] | None: ...
@property
def requires(self) -> list[str] | None: ...
Expand Down Expand Up @@ -136,10 +129,10 @@ if sys.version_info >= (3, 8):
) -> Iterable[Distribution]: ...

if sys.version_info >= (3, 10):
def metadata(self) -> PackageMetadata: ...
def metadata(distribution_name: str) -> PackageMetadata: ...
def entry_points() -> SelectableGroups: ...
Comment thread
srittau marked this conversation as resolved.
Outdated
else:
def metadata(self) -> Message: ...
def metadata(distribution_name: str) -> Message: ...
def entry_points() -> dict[str, tuple[EntryPoint, ...]]: ...

def version(distribution_name: str) -> str: ...
Expand Down