Skip to content

Add mixins module to asyncio #6789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 10 commits into from
Jan 25, 2022
Merged

Add mixins module to asyncio #6789

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0702728
Add `mixins` module to `asyncio`
sobolevn Jan 2, 2022
7d2391c
Create mixins.pyi
sobolevn Jan 2, 2022
79e75fb
Update mixins.pyi
sobolevn Jan 2, 2022
8cd351a
Merge branch 'master' into patch-59
sobolevn Jan 25, 2022
8a5eeb9
Update py36.txt
sobolevn Jan 25, 2022
91c30ed
Update py37.txt
sobolevn Jan 25, 2022
cde6e28
Update py38.txt
sobolevn Jan 25, 2022
8a22d7b
Update py39.txt
sobolevn Jan 25, 2022
b1411d6
Update mixins.pyi
sobolevn Jan 25, 2022
a7fb6c8
Update mixins.pyi
sobolevn Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stdlib/VERSIONS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ array: 2.7-
ast: 2.7-
asynchat: 2.7-
asyncio: 3.4-
asyncio.mixins: 3.10-
Copy link
Copy Markdown
Member Author

@sobolevn sobolevn Jan 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stubtest is still failing for <3.9 🤔
https://github.com/python/typeshed/runs/4686388253?check_suite_focus=true

Copy link
Copy Markdown
Collaborator

@srittau srittau Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobolevn In theory, mypy should support this: python/mypy#11069, but in practice, asyncio.exceptions is also ignored in the stubtest allowlists. You need to do the same with asyncio.mixins for now.

Copy link
Copy Markdown
Collaborator

@srittau srittau Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python/mypy#12062

asyncore: 2.7-
atexit: 2.7-
audioop: 2.7-
Expand Down
8 changes: 8 additions & 0 deletions stdlib/asyncio/mixins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import threading
from typing import Any

_global_lock: threading.Lock
_marker: object

class _LoopBoundMixin:
def __init__(self, *, loop: Any = ...) -> None: ...
Copy link
Copy Markdown
Collaborator

@srittau srittau Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just skip the loop argument, It can't really be used. Then we can also remove _marker above.