Repository navigation
paramiko: make Transport.open_sftp_client return type non-optional - #16567
Open
jacobglikz wants to merge 1 commit into
Open
jacobglikz wants to merge 1 commit into
jacobglikz wants to merge 1 commit into
Conversation
[`open_sftp_client`][1] is unable to return None as it calls [`from_transport`][2] -> [`open_session`][3] -> [`open_channel`][4], which itself [returns either a Channel or throws][5]. [1]: https://github.com/paramiko/paramiko/blob/0e9ccb91e0f9a68f2587233d523ad7fe46e730fe/paramiko/transport.py#L1138 [2]: https://github.com/paramiko/paramiko/blob/0e9ccb91e0f9a68f2587233d523ad7fe46e730fe/paramiko/sftp_client.py#L141 [3]: https://github.com/paramiko/paramiko/blob/0e9ccb91e0f9a68f2587233d523ad7fe46e730fe/paramiko/transport.py#L898 [4]: https://github.com/paramiko/paramiko/blob/0e9ccb91e0f9a68f2587233d523ad7fe46e730fe/paramiko/transport.py#L975 [5]: https://github.com/paramiko/paramiko/blob/0e9ccb91e0f9a68f2587233d523ad7fe46e730fe/paramiko/transport.py#L1063-L1068 Co-authored-by: yusuf.bham <yusuf.bham@zetier.com>
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open_sftp_clientis unable to return None as it callsfrom_transport->open_session->open_channel, which itself returns either a Channel or throws.