Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused stub changes match upstream behavior, with no unresolved correctness issues identified.
No open issues 🎉
What changed in this PR
Adds async health-service typing to typeshed’s grpcio-health-checking stubs.
Changes:
- Adds async servicer signatures and the
health.aiore-export. - Types protobuf status constants and values.
- Accepts synchronous and async gRPC channels and servers.
| File | Description |
|---|---|
| stubs/grpcio-health-checking/grpc_health/v1/health.pyi | Exports aio and updates status typing. |
| stubs/grpcio-health-checking/grpc_health/v1/health_pb2.pyi | Types status constants, fields, and constructor input. |
| stubs/grpcio-health-checking/grpc_health/v1/health_pb2_grpc.pyi | Types shared servicer methods and supports async channels and servers. |
| stubs/grpcio-health-checking/grpc_health/v1/_async.pyi | Adds async health servicer stubs. |
Review effort: Balanced
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from grpc_health.v1.health import aiocurrently has no stub. Add the async servicer and re-export, type the protobuf status values, and allow registration with an aio server.Implementation:
Validated with the typeshed checks, including stubtest, and an async health service runtime smoke test.