Skip to content

_operator: Accept readable buffers in _compare_digest #16211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightcityblade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

_operator: Accept readable buffers in _compare_digest #16211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stdlib/_operator.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import sys
from _typeshed import (
ReadableBuffer,
SupportsAdd,
SupportsGetItem,
SupportsMod,
Expand Down Expand Up @@ -150,6 +151,9 @@ def ixor(a, b, /): ...
if sys.version_info >= (3, 11):
def call(obj: Callable[_P, _R], /, *args: _P.args, **kwargs: _P.kwargs) -> _R: ...

@overload
def _compare_digest(a: ReadableBuffer, b: ReadableBuffer, /) -> bool: ...
@overload
def _compare_digest(a: AnyStr, b: AnyStr, /) -> bool: ...

@JelleZijlstra JelleZijlstra Aug 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now simplify the second overload to take str instead of AnyStr, right?


if sys.version_info >= (3, 14):
Expand Down