Skip to content

Fix blake2 binding#1609

Closed
i80and wants to merge 1 commit into
python:masterfrom
i80and:fix-blake2-binding
Closed

Fix blake2 binding#1609
i80and wants to merge 1 commit into
python:masterfrom
i80and:fix-blake2-binding

Conversation

@i80and

@i80and i80and commented Sep 15, 2017

Copy link
Copy Markdown

Currently calling hashlib.blake2b results in the following type errors:

<...>: error: Cannot instantiate abstract class '_BlakeHash' with abstract attributes 'copy', 'digest', 'hexdigest' and 'update'
<...>: error: Missing positional arguments "data", "key", "salt", "person", "fanout", "depth", "leaf_size", "node_offset", "node_depth", "inner_size", "last_node" in call to "_BlakeHash"

Currently calling `hashlib.blake2b` results in the following type errors:

Cannot instantiate abstract class '_BlakeHash' with abstract attributes 'copy', 'digest', 'hexdigest' and 'update'
Missing positional arguments "data", "key", "salt", "person", "fanout", "depth", "leaf_size", "node_offset", "node_depth", "inner_size", "last_node" in call to "_BlakeHash"
@JelleZijlstra

Copy link
Copy Markdown
Member

Would it be better to instead correct the definition of _BlakeHash? At the very least, we should add a default for the data argument.

@JelleZijlstra

Copy link
Copy Markdown
Member

Ping on the above.

@quantsini

Copy link
Copy Markdown
Contributor

Any objection to me taking over this change?
Happy to make a new branch, cherrypick this commit, and addressing @JelleZijlstra's comment in a new PR.

@i80and

i80and commented Oct 10, 2017

Copy link
Copy Markdown
Author

No objection from me! Sorry, I just don't have time immediately to take a look at this.

Thanks :)

@i80and i80and closed this Oct 10, 2017
@quantsini quantsini mentioned this pull request Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants