[site] add(user)sitepackages(known_paths) shouldn't be None#15866
Open
srittau wants to merge 1 commit into
Open
[site] add(user)sitepackages(known_paths) shouldn't be None#15866srittau wants to merge 1 commit into
add(user)sitepackages(known_paths) shouldn't be None#15866srittau wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
|
Why? They just pass known_paths on to addsitedir, which does accept None for known_paths. Here is the code for 3.14: https://github.com/python/cpython/blob/35ec25553e7ab13c7a3ad90a3ecd2bc27a8fcd5e/Lib/site.py#L423 |
Collaborator
Author
|
Yes, but that is kind of pointless, and indicates a misunderstanding of the API. (At least that is how I understand the API.) Also, if we allow Overall, not a super significant change, but an improvement, in my opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.