Fix return type of requests.utils.select_proxy#15777
Closed
mrhx01 wants to merge 5 commits into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
|
This is a no-op now. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type annotations in requests.utils.
This PR fixes two inconsistencies between the runtime implementation and the typeshed stubs:
select_proxymay returnNonewhen no matching proxy is found, so the return type should bestr | None.should_bypass_proxiesacceptsstr | Nonefor theno_proxyparameter in the runtime implementation, but the stub currently annotates it asIterable[str] | None.These changes align the stubs with the actual runtime behavior.