Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/computation/ops.py:328: error: Need type annotation for "_binary_ops_dict" (hint: "_binary_ops_dict: dict[<type>, <type>] = ...") [var-annotated]
|
Collaborator
Author
|
Timing seems to work fine, in this PR the last mypy_primer shard completed less than 30 seconds later than everything else. But why does this affect the output of mypy_primer? |
Collaborator
Author
|
(I also just noticed that today I've been pushing directly here rather than my own fork. Oops :) ) |
Member
|
This is a known flake where mypy is nondeterministic, Shantanu put up a fix in mypy. |
JelleZijlstra
approved these changes
May 11, 2026
Collaborator
No worries, I think a few maintainers prefer branches in this repo instead of their own copy, and that's fine. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI on pull requests seems to take about 6 minutes, and the slowest thing is mypy_primer. Everything else is done in about 4 minutes. If this PR works like I intend, it will shorten the total CI time to about 4 minutes.