Skip to content

[functools] Use ParamSpec for single dispatch #15635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
srittau wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

[functools] Use ParamSpec for single dispatch #15635

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b054f06
[functools] Use ParamSpec for single dispatch
srittau Apr 8, 2026
8d46a85
Use Concatenate
srittau Apr 8, 2026
a79bb75
Fix one overload
srittau Apr 8, 2026
b50ff5f
Ignore away all the errors
srittau Apr 8, 2026
7b3519a
Add tests
srittau Apr 8, 2026
d9eb0a0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 8, 2026
9ec49de
Add a type ignore????
srittau Apr 8, 2026
302109e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 8, 2026
e004de4
Remove assert type
srittau Apr 8, 2026
ca066fb
Remove unused import
srittau Apr 8, 2026
1bc06b1
Merge branch 'main' into singledispatch
srittau Apr 8, 2026
ba3c5da
Fix aiofiles problem
srittau Apr 8, 2026
5e23409
Use defaults for `_SingleDispatchCallable`
srittau Apr 8, 2026
3cfe03a
Fix default
srittau Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a type ignore????
  • Loading branch information
@srittau
srittau committed Apr 8, 2026
commit 9ec49de530659ee9fd435c5a4e26ba48493eb9e2
2 changes: 1 addition & 1 deletion stubs/aiofiles/aiofiles/threadpool/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
) -> AiofilesContextManager[_UnknownAsyncBinaryIO]: ...

stdin: AsyncTextIndirectIOWrapper
stdout: AsyncTextIndirectIOWrapper
stdout: AsyncTextIndirectIOWrapper # type: ignore # ???

Check failure on line 102 in stubs/aiofiles/aiofiles/threadpool/__init__.pyi

View workflow job for this annotation

GitHub Actions / pyright: Run test cases (Linux, 3.13) 

Too few type arguments provided for "_SingleDispatchCallable"; expected 2 but received 1 (reportInvalidTypeArguments)
stderr: AsyncTextIndirectIOWrapper
stdin_bytes: AsyncIndirectBufferedIOBase
stdout_bytes: AsyncIndirectBufferedIOBase
Expand Down
Loading