Skip to content

Fix typing of reversed #10655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 19 commits into from
Feb 16, 2024
Merged

Fix typing of reversed #10655

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0dfbde9
Fix typing of reversed
plokmijnuhby Sep 3, 2023
b0e754f
Ignore errors
plokmijnuhby Sep 3, 2023
406c07b
Replace self with cls
plokmijnuhby Sep 4, 2023
64cbf71
Create test_reversed.py
plokmijnuhby Sep 26, 2023
2abadcb
Rename test_reversed.py to check_reversed.py
plokmijnuhby Sep 26, 2023
884d429
Update check_reversed.py
plokmijnuhby Sep 26, 2023
e475f46
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 26, 2023
79e15c9
Add more checks
plokmijnuhby Sep 26, 2023
2aa3d06
Fix a typo
plokmijnuhby Sep 26, 2023
d2d5318
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 26, 2023
662d99c
Correct name of typevar
plokmijnuhby Sep 26, 2023
f717387
Replace iterable with reversible
plokmijnuhby Sep 26, 2023
2521747
Fix myreversible class
plokmijnuhby Sep 26, 2023
e7a86d7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 26, 2023
b965611
Put list[..] in quotes
plokmijnuhby Sep 26, 2023
a5c06b3
Add annotation to __len__
plokmijnuhby Sep 26, 2023
593e7df
Update test_cases/stdlib/builtins/check_reversed.py
JelleZijlstra Feb 16, 2024
d42f199
Merge branch 'main' into patch-2
JelleZijlstra Feb 16, 2024
eb66889
Update test_cases/stdlib/builtins/check_reversed.py
JelleZijlstra Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Sep 26, 2023
commit d2d53189925629a9ed489d9510dbd83b1ab76a50
6 changes: 5 additions & 1 deletion test_cases/stdlib/builtins/check_reversed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@
iterator = iter(x)
assert_type(list(reversed(iterator)), list[int])


class MyIterable:
def __iter__(self):
yield "blah"


assert_type(list(reversed(MyIterable())), list[str])

_T = TypeVar('T')
_T = TypeVar("T")


class MyLenAndGetItem(Generic[_T]):
def __len__(self):
Expand Down