Skip to content

Add stubs for WTForms #10557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 11 commits into from
Sep 29, 2023
Merged

Add stubs for WTForms #10557

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
57ff219
Add stubs for WTForms
Daverball Aug 9, 2023
8a23f8d
Removes redundant method override that was still untyped
Daverball Aug 10, 2023
fba94a6
Fixes pytype crash
Daverball Aug 10, 2023
6dd2253
Merge branch 'main' into wtforms
JelleZijlstra Aug 10, 2023
e0eb791
Fixes return type of `wtforms.form.BaseForm.errors`
Daverball Aug 16, 2023
224488a
Apply suggestions from code review
Daverball Sep 23, 2023
ee0615b
Properly works around potential shadowing of `builtins.type`
Daverball Sep 23, 2023
020fae8
Adds a type alias to avoid a potentially ambiguous cyclic name reference
Daverball Sep 23, 2023
28fec0b
Came up with a better solution for the pytype crash
Daverball Sep 23, 2023
7fce4bc
removes `type` that was accidentally left in
Daverball Sep 23, 2023
fe6d09c
Improves type safety of `Form._unbound_fields`
Daverball Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Properly works around potential shadowing of builtins.type
  • Loading branch information
@Daverball
Daverball committed Sep 23, 2023
commit ee0615b444c5b1d6a659d5f000471df26a6896c2
9 changes: 4 additions & 5 deletions stubs/WTForms/wtforms/fields/core.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from builtins import type as _type # type is being shadowed in Field
from collections.abc import Callable, Iterable, Sequence
from typing import Any, Generic, Protocol, TypeVar, overload
from typing_extensions import Self, TypeAlias
Expand Down Expand Up @@ -41,6 +42,7 @@ class Field:
name: str
short_name: str
id: str
type: str
label: Label
# technically this can return UnboundField, but that is not allowed
Comment thread
JelleZijlstra marked this conversation as resolved.
# by type checkers, so we use a descriptor hack to get around this
Expand Down Expand Up @@ -92,12 +94,9 @@ class Field:
# This workaround only works for Form, not BaseForm, but we take what we can get
# BaseForm shouldn't really be used anyways
@overload
def __get__(self, obj: None, owner: type[object] | None = None) -> UnboundField[Self]: ...
def __get__(self, obj: None, owner: _type[object] | None = None) -> UnboundField[Self]: ...
@overload
def __get__(self, obj: object, owner: type[object] | None = None) -> Self: ...

# we put this at the bottom so it doesn't shadow builtins.type
type: str
def __get__(self, obj: object, owner: _type[object] | None = None) -> Self: ...

class UnboundField(Generic[_FieldT]):
creation_counter: int
Expand Down