Skip to content

Traduccion Archivo warnings.po#329

Merged
humitos merged 20 commits into
python:3.8from
gomezgleonardob:traduccion-warnings.po
Jun 10, 2020
Merged

Traduccion Archivo warnings.po#329
humitos merged 20 commits into
python:3.8from
gomezgleonardob:traduccion-warnings.po

Conversation

@gomezgleonardob
Copy link
Copy Markdown
Contributor

@gomezgleonardob gomezgleonardob commented May 22, 2020

  • Traducción Archivo
  • Agregar nombre a Translators

@cmaureir
Copy link
Copy Markdown
Collaborator

cmaureir commented May 22, 2020

En unos de mis PR también agregué ésimo al `dict, que es la palabra que te falla. Yo que tu la agrego igual :)

@gomezgleonardob
Copy link
Copy Markdown
Contributor Author

gomezgleonardob commented May 22, 2020

@cmaureir si ya la agrego al dict , gracias

@humitos humitos requested a review from cmaureir May 23, 2020 13:29
@cmaureir
Copy link
Copy Markdown
Collaborator

cmaureir commented May 23, 2020

Aún hay conflictos en el dict, a ver que nos dice Travis cuando los solociones @gomezgleonardob . Recuerda que los puedes resolver aqui mismo en Github

@gomezgleonardob
Copy link
Copy Markdown
Contributor Author

gomezgleonardob commented May 23, 2020

Corregido los errores, se agradece una review :)

cmaureir
cmaureir requested changes May 24, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cmaureir cmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un par de detallitos y estamos

Comment thread library/warnings.po Outdated
Comment thread library/warnings.po Outdated
Comment thread library/warnings.po Outdated
Comment thread dict
Comment thread dict Outdated
@humitos
Copy link
Copy Markdown
Collaborator

humitos commented May 29, 2020

@gomezgleonardob el build está fallando por algo, ¿lo puedes revisar?

@cmaureir ¿quieres terminar de hacer la review de esta PR?

@gomezgleonardob
Copy link
Copy Markdown
Contributor Author

gomezgleonardob commented May 29, 2020

@humitos ya reviso hoy

humitos
humitos requested changes May 30, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Genial! Te dejé algunos comentarios para que los revises. Creo que luego de eso estamos para hacer merge. Gracias!

Comment thread dict
Comment thread dict Outdated
Comment thread dict Outdated
Comment thread library/warnings.po Outdated
clacri
clacri reviewed May 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@clacri clacri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sólo he podido echar un vistazo rápidamente. Muchas gracias !

Comment thread library/warnings.po
cmaureir
cmaureir approved these changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cmaureir cmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mi me parece bien este cambio :) Gracias @gomezgleonardob

@humitos humitos merged commit eeec3af into python:3.8 Jun 10, 2020
@humitos humitos mentioned this pull request Jun 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humitos humitos humitos requested changes

@cmaureir cmaureir cmaureir approved these changes

+1 more reviewer

@clacri clacri clacri left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gomezgleonardob @cmaureir @humitos @clacri @leonard0x00