Optimizada sincronización con CPython en CI#1186
Merged
cmaureir merged 2 commits intopython:3.9from Aug 2, 2021
Merged
Conversation
e210388 to
76bd613
Compare
76bd613 to
8c150f1
Compare
eamanu
reviewed
Dec 24, 2020
Contributor
eamanu
left a comment
There was a problem hiding this comment.
Me parece bien. Podrías cerrar y volver abrir el pr a ver si corre el CI? A nosotros nos interesa el proyecto no? No la historia git cierto? Se podría pensar en hacer algún wget para traer el proyecto?
Contributor
Author
Probé a hacer un simple clone pero fallaba en el paso de construir la documentación con algunas directivas |
cmaureir
approved these changes
Aug 2, 2021
cmaureir
added a commit
that referenced
this pull request
Aug 4, 2021
Co-authored-by: Cristián Maureira-Fredes <Cristian.Maureira-Fredes@qt.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Este pull optimiza la sincronización con CPython en el CI, ahorrando como mínimo 1 minuto. El problema es que la configuración actual realiza un clone completo (incluído historial GIT) de
python/cpython, pero esto no es necesario y será cada vez más costoso a medida que más commits sean añadidos a CPython. Añadiendo--depth=1agit submodule updatey eliminando el comando redundantegit submodule sync, obtenemos el mismo resultado que actualmente en menos tiempo.