Skip to content

Incorrect isinstance(..., 'str') check, test _pyproject_toml #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 6 commits into from
Oct 23, 2025
Merged

Incorrect isinstance(..., 'str') check, test _pyproject_toml #413

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb91f98
ups?
maurycy Sep 13, 2025
bd5e2d2
test pyproject
maurycy Sep 20, 2025
76e477d
Merge branch 'main' into incorrect-str-isinstance
maurycy Sep 22, 2025
4e4b2d8
uvx ruff format pyperformance/tests/test_pyproject_toml.py
maurycy Sep 22, 2025
24846a8
fix odd indent
maurycy Sep 22, 2025
d31b644
consistent new lines
maurycy Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix odd indent
  • Loading branch information
@maurycy
maurycy committed Sep 22, 2025
commit 24846a8036038d6a717ca4f01b3165ccb66b5f2a
18 changes: 9 additions & 9 deletions pyperformance/tests/test_pyproject_toml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,23 +46,23 @@ def test_parse_full_valid_project_section(self):
def test_parse_fails_on_missing_name(self):
with tempfile.TemporaryDirectory() as tmpdir:
toml_content = """
[project]
version = "1.0"
"""
[project]
version = "1.0"
"""

with self.assertRaisesRegex(ValueError, r'missing required "name" field'):
_pyproject_toml.parse_pyproject_toml(toml_content, rootdir=str(tmpdir))

def test_parse_fails_on_unsupported_section(self):
with tempfile.TemporaryDirectory() as tmpdir:
toml_content = """
[project]
name = "my-test-bench"
version = "1.0"
[project]
name = "my-test-bench"
version = "1.0"

[foobar]
key = "value"
"""
[foobar]
key = "value"
"""

with self.assertRaisesRegex(ValueError, "unsupported sections"):
_pyproject_toml.parse_pyproject_toml(toml_content, rootdir=str(tmpdir))
Expand Down
Loading