Skip to content

compile: read git_remote from the [scm] section #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nelhage wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compile: read git_remote from the [scm] section #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
compile: read git_remote from the [scm] section 
The example configuration (`doc/benchmark.conf.sample`) and the
configuration in `test_commands.py` both expect it to be there.

Add a fallback in case anyone has existing configurations with it set
under `[config]`.
  • Loading branch information
@nelhage
nelhage committed Feb 11, 2025
commit 6881f415a9a20321af7c809080fc0469e27079db
7 changes: 6 additions & 1 deletion pyperformance/compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,12 @@ def getint(section, key, default=None):
# [scm]
conf.repo_dir = getfile('scm', 'repo_dir')
conf.update = getboolean('scm', 'update', True)
conf.git_remote = getstr('config', 'git_remote', default='remotes/origin')
try:
conf.git_remote = getstr('scm', 'git_remote')
except KeyError:
# This key used to live under `config`. Fall back there
# for backwards-compatibility.
conf.git_remote = getstr('config', 'git_remote', default='remotes/origin')

# [compile]
conf.directory = getfile('compile', 'bench_dir')
Expand Down