Skip to content

Make benchmarking 25% faster by parallelizing benchmarking venv setup #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fidget-Spinner wants to merge 4 commits into from
Closed

Make benchmarking 25% faster by parallelizing benchmarking venv setup #375

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecbfbf0
Parallelize benchmarking venv setup
Fidget-Spinner Dec 16, 2024
db29d34
fix bug
Fidget-Spinner Dec 16, 2024
aefde59
Use threads because windows is unhappy
Fidget-Spinner Dec 16, 2024
0cfc548
switch back to processpoolexecutor
Fidget-Spinner Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix bug
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Dec 16, 2024
commit db29d34b0710e4eceded138fb11528f610864cd7
2 changes: 1 addition & 1 deletion pyperformance/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def run_benchmarks(should_run, python, options):
executor_input = [(i+1, len(to_run), python, options, bench)
for i, bench in enumerate(to_run[1:])]
# It's fine to set a higher worker count, because this is IO-bound anyways.
with concurrent.futures.ProcessPoolExecutor(max_workers=len(to_run)-1) as executor:
with concurrent.futures.ProcessPoolExecutor(max_workers=max(1, len(to_run))) as executor:
for bench, venv_root, venv, bench_runid, cons_output in executor.map(setup_single_venv, executor_input):
if venv_root is not None:
venvs.add(venv_root)
Expand Down