Skip to content

Add logging message to notify user of skipped benchmarks #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bclodius wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add logging message to notify user of skipped benchmarks #316

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df9e29
Add logging message to notify user of skipped benchmarks
Oct 9, 2023
8f90290
Implement review comments
Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Implement review comments
  • Loading branch information
bclodius committed Oct 9, 2023
commit 8f90290cb2c196f7183ab9ad71e4b0d0044248b3
6 changes: 2 additions & 4 deletions pyperformance/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,8 @@ def parse_entry(o, s):
if this_python_version in bench.python:
selected.append(bench)
else:
message = (f"Benchmark: {bench.spec.name} is being skipped because "
f"python version required is {bench.python} "
f"but found {this_python_version}")
logging.info(message)
logging.warning("Benchmark: %s is being skipped because Python version required is %s but found %s",
bench.spec.name, bench.python, this_python_version)

return selected

Expand Down