Skip to content

Add mypy config; run mypy in CI #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 2 commits into from
May 10, 2023
+62 −3
Merged

Add mypy config; run mypy in CI #286

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7a222f
Add mypy config; run mypy in CI
AlexWaygood May 2, 2023
7d9b5f7
Add `--strict-concatenate`
AlexWaygood May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add --strict-concatenate
  • Loading branch information
@AlexWaygood
AlexWaygood authored May 5, 2023
commit 7d9b5f7bbc8257408be77fec63c86597810307af
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ python_version = "3.7"
pretty = true
enable_error_code = "ignore-without-code"
Copy link
Copy Markdown
Member Author

@AlexWaygood AlexWaygood May 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that mypy will emit an error if you do a bare # type: ignore without a specific error code (e.g. you should use # type: ignore[import] to suppress mypy's import-related errors)

disallow_any_generics = true
Copy link
Copy Markdown
Member Author

@AlexWaygood AlexWaygood May 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that mypy will forbid using, for example, list or typing.List as an annotation. You should use list[int] or typing.List[int] instead, which gives the type checker much more information to work with.

strict_concatenate = true
Copy link
Copy Markdown
Member Author

@AlexWaygood AlexWaygood May 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt we'll be making much use of typing.Concatenate in pyperformance, but this is one of the stricter settings that mypy offers which can be easily enabled from the get-go, so we may as well enable it now

warn_redundant_casts = true
warn_unused_ignores = true
warn_unused_configs = true
Expand Down