Skip to content

On older versions of Python, skip benchmarks that use features introduced in newer Python versions #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 5 commits into from
Apr 27, 2023
+11 −3
Merged

On older versions of Python, skip benchmarks that use features introduced in newer Python versions #283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2eea05b
On older versions of Python, skip benchmarks that use features introd…
AlexWaygood Apr 26, 2023
8153afb
Fix tests on 3.7
AlexWaygood Apr 26, 2023
1734919
Add a benchmark that uses features new in 3.8
AlexWaygood Apr 26, 2023
65e1161
Revert "Add a benchmark that uses features new in 3.8"
AlexWaygood Apr 26, 2023
a27d708
Apply suggestions from code review
AlexWaygood Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
  • Loading branch information
@AlexWaygood @brandtbucher
AlexWaygood and brandtbucher authored Apr 27, 2023
commit a27d70888c116ea64e13ae45142cf4240641b9b3
3 changes: 1 addition & 2 deletions pyperformance/_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,7 @@ def extra_opts(self):

@property
def python(self):
req = self._get_metadata_value("python", None)
return None if req is None else SpecifierSet(req)
return SpecifierSet(self._get_metadata_value("python", ""))

# Other metadata keys:
# * base
Expand Down
2 changes: 1 addition & 1 deletion pyperformance/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ def parse_entry(o, s):
logging.warning(f"no benchmark named {bench!r}")
continue
# Filter out any benchmarks that can't be run on the Python version we're running
if bench.python is not None and this_python_version in bench.python:
if this_python_version in bench.python:
selected.append(bench)

return selected
Expand Down