Skip to content

Preserve the Exit Code of Running the Tests #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 6 commits into from
Mar 28, 2022
Merged

Preserve the Exit Code of Running the Tests #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53ef81e
Preserve the Exit Code of Running the Tests
ericsnowcurrently Mar 28, 2022
ad76fbc
Skip compile tests if not CPython.
ericsnowcurrently Mar 28, 2022
80f5cd6
Add a temporary diagnistic.
ericsnowcurrently Mar 28, 2022
a846db6
Drop the diagnostic.
ericsnowcurrently Mar 28, 2022
b0511f3
Check exit codes in tests.
ericsnowcurrently Mar 28, 2022
2fbcbdc
Fix the exit code checks.
ericsnowcurrently Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions pyperformance/tests/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import os
import os.path
import shutil
import subprocess
import sys
import textwrap
import unittest
Expand All @@ -10,6 +9,12 @@
from pyperformance import tests


CPYTHON_ONLY = unittest.skipIf(
sys.implementation.name != 'cpython',
'CPython-only',
)


class FullStackTests(tests.Functional, unittest.TestCase):

maxDiff = 80 * 100
Expand All @@ -24,12 +29,13 @@ def setUpClass(cls):

@classmethod
def ensure_pyperformance(cls):
_, stdout, _ = cls.run_python(
ec, stdout, _ = cls.run_python(
os.path.join(tests.DATA_DIR, 'find-pyperformance.py'),
capture='stdout',
onfail='raise',
verbose=False,
)
assert ec == 0, ec
stdout = stdout.strip()
if stdout.strip():
# It is already installed.
Expand All @@ -43,7 +49,8 @@ def ensure_pyperformance(cls):
# Install it.
reporoot = os.path.dirname(pyperformance.PKG_ROOT)
# XXX Ignore the output (and optionally log it).
cls.run_pip('install', '--editable', reporoot)
ec, _, _ = cls.run_pip('install', '--editable', reporoot)
assert ec == 0, ec

# Clean up extraneous files.
egg_info = "pyperformance.egg-info"
Expand Down Expand Up @@ -252,6 +259,7 @@ def create_compile_config(self, *revisions,
outfile.write(text)
return cfgfile

@CPYTHON_ONLY
@unittest.skip('way too slow')
def test_compile(self):
cfgfile = self.create_compile_config()
Expand All @@ -263,6 +271,7 @@ def test_compile(self):
capture=None,
)

@CPYTHON_ONLY
@unittest.skip('way too slow')
def test_compile_all(self):
rev1 = '2cd268a3a934' # tag: v3.10.1
Expand All @@ -275,6 +284,7 @@ def test_compile_all(self):
capture=None,
)

@CPYTHON_ONLY
@unittest.expectedFailure
def test_upload(self):
url = '<bogus>'
Expand Down
3 changes: 2 additions & 1 deletion runtests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@ def main():
# <unreachable>

# Now run the tests.
subprocess.run(
proc = subprocess.run(
[sys.executable, '-u', '-m', 'pyperformance.tests'],
cwd=os.path.dirname(__file__) or None,
env=dict(
os.environ,
PYPERFORMANCE_TESTS_VENV=venvroot,
)
)
sys.exit(proc.returncode)


if __name__ == "__main__":
Expand Down