Skip to content

Avoid crashing when invalid __install__.json file exists. #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 8 commits into from
Mar 31, 2026
Merged

Avoid crashing when invalid __install__.json file exists. #299

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
55390c5
Avoid crashing when invalid __install__.json file exists.
zooba Mar 31, 2026
c7d5b43
Improve purge to clean up unrecognised directories
zooba Mar 31, 2026
a9d2ce4
Set install_dir on test config
zooba Mar 31, 2026
2b50aaf
Use iterdir not listdir
zooba Mar 31, 2026
c99a712
Add purge to test run
zooba Mar 31, 2026
e7370ce
Simplify and use helpers
zooba Mar 31, 2026
819e54a
Allow path to be deleted in test
zooba Mar 31, 2026
d8dcd94
Don't purge everything anymore
zooba Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't purge everything anymore
  • Loading branch information
@zooba
zooba committed Mar 31, 2026
commit d8dcd941e1a14f891356155e21780e697724bd7f
8 changes: 0 additions & 8 deletions src/manage/uninstall_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,6 @@ def execute(cmd):
for _, cleanup in SHORTCUT_HANDLERS.values():
if cleanup:
cleanup(cmd, [])
# Clean up other lingering directories
LOGGER.info("Purging remaining files")
for d in _iterdir(cmd.install_dir):
if d.is_dir():
LOGGER.verbose("Removing %s", d)
rmtree(d, after_5s_warning=warn_msg.format("remaining files"))
if any(_iterdir(cmd.install_dir)):
LOGGER.warn("Unable to fully remove %s.", cmd.install_dir)
LOGGER.debug("END uninstall_command.execute")
return

Expand Down
Loading