Automatically credit remediation developers and reviewers - #61
Open
sethmlarson wants to merge 3 commits into
Open
Automatically credit remediation developers and reviewers#61sethmlarson wants to merge 3 commits into
sethmlarson wants to merge 3 commits into
Conversation
| "cve_id": cve_id, | ||
| "collaborating_teams": [{"slug": team} for team in collaborating_teams], | ||
| "collaborating_users": [{"login": "octocat", "id": 1, "type": "User"}], | ||
| "private_fork": {"name": "repo-ghsa-xxxx-xxxx-xxxx", "owner": {"login": "owner"}}, |
Member
There was a problem hiding this comment.
Won't we loose coverage?
Collaborator
Author
There was a problem hiding this comment.
I removed this field to avoid needing to mock out the pull requests response for each test case that didn't process private_fork. All the test cases that use private_fork already set the value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bot can automatically credit people who participate in creating a patch or reviewing the patch privately. Does not override credits that already exist for an individual.