-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
PEP 825: Various clarifications #4969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
konstin
wants to merge
18
commits into
python:main
Choose a base branch
from
wheelnext:pep-wheel-variants-acceptance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+171
−79
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
510c525
PEP 825: reword ordering to avoid introducing new terms
mgorny 1fd013b
PEP 825: add a note for installing from a source with no index-level …
mgorny 58778b0
PEP 825: clarify that the feature and value lists will be ordered
mgorny db4fe20
PEP 825: extend the rationale further
mgorny f5a98eb
PEP 825: Extend the rationale for index support scenarios
mgorny 7a4f9a9
PEP 825: add handling multiple sources to "Open Issues"
mgorny 68f49fc
PEP 825: clarify index-level metadata in simple repository API
mgorny c4ccf6c
PEP 825: mention replacing tags entirely in "Rejected Ideas"
mgorny 19acda7
Fix rebase
konstin bea8e82
Fix dead reference
konstin 93f883f
Merge pull request #56 from wheelnext/konsti/open-issues-out-of-scope
konstin 9d3bcf7
Update Change History (11-May-2026)
konstin 51187f6
Merge pull request #57 from wheelnext/konsti/11-may-2026
konstin d9f0f44
Update peps/pep-0825.rst
konstin 2dbbf45
PEP 825: clarify that we're talking about optional metadata attrs
mgorny 69bf1b2
PEP 825: remove stray "that"
mgorny 51e47c9
PEP 825: clarify providing namespace ordering
mgorny fce4d46
PEP 825: undefined → implementation-defined
mgorny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PEP 825: clarify index-level metadata in simple repository API
- Loading branch information
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're putting
variant.jsonfiles in thefilessection of the JSON response, then you need to follow the existing rules, which say that for eachfilesentry,filename,url,hashesandsizeare mandatory, and all other keys are optional. There's nothing in the existing spec that suggests that tools can ignore attributes if they are present, and I don't think we should be special-casingvariant.jsonfiles.I actually don't understand why you're allowing these fields to be present at all. What's wrong with simply saying that
variant.jsonfiles must not include any of the optional fields defined in the index spec (with the exception of theupload-timefield, which may be present)1?Honestly, this feels like a problem caused by trying to put
variant.jsonfiles into a field that's intended to hold details of distribution files. I'd argue that a cleaner design would be to have a separatevariant-datafield in the project details response2.Footnotes
I'm only making an exception for upload time because I can see cases where it might be useful, in analysing index data. ↩
The HTML version of the index would still need to have all the links together, but that should be viewed as secondary, as per PEP 833 (which is not yet approved, but is likely to be). ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, "optional fields" is what we meant. We'll correct this.
For the rest, see rationale. The goal is to support indexes during the transitional period with minimal modifications necessary. Should the tools be rejecting projects if the index gives unnecessary-yet-harmless fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically note the provision:
This is intended as "you don't have to go out of your way to special case that one file", as long as you don't do something really wrong there.