PEP 1: Update "issue tracker" to link to GitHub Issues - #2568

Yep, seems good. 👍 Might also be worth saying "pull request" rather than "patch submission".

Might also be worth saying "pull request" rather than "patch submission".

oh, good call!

this could use a little wordsmithing.

the current sentence is:

Small enhancements or patches often don't need
a PEP and can be injected into the Python development workflow with a
patch submission to the Python issue tracker.

I think changing "patch submission" to "pull request" would cause more confusion, since pull requests are not created via the issue tracker (as perhaps patches were attached to BPO issue in the past).

to make this accurate, we need to say something along these lines:

Small enhancements or changes often don't need a PEP and
can be integrated into the Python development workflow by reporting
an issue to the Python issue tracker and submitting a pull request.

if this looks good, I'll update the PR with the changes.

@itamaro that wording sounds good to me.

On GitHub, the issue tracker manages pull requests too, so it's not terribly wrong. What about this slight change?

Small enhancements or changes often don't need a PEP and
can be integrated into the Python development workflow by reporting
an issue to the Python issue tracker and/or submitting a pull request.

thanks for the feedback and suggestions - update the PR and added a link to GitHub pull requests too

That's better, though IMO that sentence can be made a lot simpler, and I don't know if its wise to push users directly to pull requests since any non-trivial change requires an issue. Also, due to the automatic re-wrapping to fit the hard breaks, it ends up touching a fairly substantial number of lines and is hard to see what was actually modified,

What about this change as implemented on this branch instead?

What about this change as implemented on this branch instead?

that looks good to me

s/Small enhancements/Most enhancements/ in either version -- de facto only substantive changes go through the PEP process.

A

+0 to Cam's wording over the one proposed in this PR, +1 to the change in general.

A

After in-person discussion with @itamaro , he asked me to go ahead and push a commit with a slightly modified form of my proposed revision.

Thanks @itamaro!

A