Skip to content

PEP 7: prefer static inline functions - #2315

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:pep7_static_inline
Feb 8, 2022
Merged

PEP 7: prefer static inline functions#2315
vstinner merged 1 commit into
python:mainfrom
vstinner:pep7_static_inline

Conversation

@vstinner

@vstinner vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member

No description provided.

@vstinner

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

Apply SC's request related to the PEP 670.

@vstinner

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

cc @encukou

hugovk
hugovk reviewed Feb 8, 2022
View reviewed changes
Comment thread pep-0007.txt Outdated
@vstinner

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

Not sure we should mention PEP 670 at all, given that the PEP as a whole has not yet been decided on.

It's half accepted and the decision comes from there. No?

@vstinner
vstinner merged commit c0fc47a into python:main Feb 8, 2022
@vstinner
vstinner deleted the pep7_static_inline branch February 8, 2022 17:45
@vstinner

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

Ok, I merged my PR.

@vstinner

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

Thanks for the reviews!

@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@hugovk hugovk hugovk left review comments
@erlend-aasland erlend-aasland erlend-aasland left review comments
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @JelleZijlstra @hugovk @erlend-aasland @the-knights-who-say-ni