Skip to content

PEP 634: Clarify late-registration edge-case #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 2 commits into from
Jun 24, 2021
Merged

PEP 634: Clarify late-registration edge-case #2001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e853e41
Clarify late-registration edge-case
brandtbucher Jun 24, 2021
609e1c5
Add myself as a CODEOWNER for PEPs 635 and 636
brandtbucher Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,8 +489,8 @@ pep-0631.rst @pganssle
pep-0632.rst @zooba
pep-0633.rst @brettcannon
pep-0634.rst @brandtbucher @gvanrossum
pep-0635.rst @gvanrossum
pep-0636.rst @gvanrossum
pep-0635.rst @brandtbucher @gvanrossum
pep-0636.rst @brandtbucher @gvanrossum
pep-0637.rst @stevendaprano
pep-0638.rst @markshannon
pep-0639.rst @pfmoore
Expand Down
6 changes: 4 additions & 2 deletions pep-0634.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,8 @@ where being a sequence is defined as its class being one of the following:
- a class that inherits from ``collections.abc.Sequence``
- a Python class that has been registered as a ``collections.abc.Sequence``
- a builtin class that has its ``Py_TPFLAGS_SEQUENCE`` bit set
- a class that inherits from any of the above.
- a class that inherits from any of the above (including classes defined *before* a
parent's ``Sequence`` registration)

The following standard library classes will have their ``Py_TPFLAGS_SEQUENCE``
bit set:
Expand Down Expand Up @@ -440,7 +441,8 @@ where being a mapping is defined as its class being one of the following:
- a class that inherits from ``collections.abc.Mapping``
- a Python class that has been registered as a ``collections.abc.Mapping``
- a builtin class that has its ``Py_TPFLAGS_MAPPING`` bit set
- a class that inherits from any of the above.
- a class that inherits from any of the above (including classes defined *before* a
parent's ``Mapping`` registration)

The standard library classes ``dict`` and ``mappingproxy`` will have their ``Py_TPFLAGS_MAPPING``
bit set.
Expand Down