[mypyc] Generate names lazily when pretty-printing IR or generating C#9767
Merged
Conversation
The _... suffixes can be hard to distinguish if there are many underscores.
Collaborator
Author
|
I'm going to merge this as soon as the builds are green, since I have several other PRs I want to create that depend on this (and this doesn't change behavior). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of generating names for ops when building IR, we now generate names
immediately before pretty-printing or generating C. This simplifies
Environmentand reduces the amount of mutable state we need to maintain. This a step
towards removing the
mypyc.ir.ops.Environmentclass.Move code related to pretty-printing to
mypyc.ir.pprint.Work on mypyc/mypyc#781.